[klee-dev] [klee-commits] [PATCH 3/3] Fix NotExpr::computeHash() shadowing hashValue

[Jonathan Neuschäfer]

On Thu, Jul 11, 2013 at 05:45:58PM +0100, Cristian Cadar wrote:
> Hi Jonathan,
> 
> Thanks for these three patches; nice catch with the last one.
> 
> There were again no commit messages going to klee-commits about your
> patches; after some googling, I found out that commit messages
> containing non-ASCII characters are discarded, see the thread below:
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080428/061915.html

That's interesting.

> So from now on I will unfortunately have to misspell your last name
> as Neuschafer, sorry!

"Neuschaefer" would be the more common spelling in cases where the A
"umlaut" isn't available, such as in my email address. I'll leave up it
to you which spelling you'll use.  :-)

> 
> Finally, I would prefer to use klee-commits for patches, unless they
> are likely to be of interest to the wider klee-dev audience.

Ok, I'll remember that.


--
Jonathan

> 
> Best,
> Cristian
> 
> On 01/07/13 22:25, Jonathan Neuschäfer wrote:
> >Without this patch NotExpr::computeHash() will have a local
> >valiable with the name "hashValue" and assign the newly computed
> >hash to that instead of the member variable with the same name
> >that should be set by the computeHash method of every Expr subclass.
> >---
> >  lib/Expr/Expr.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/lib/Expr/Expr.cpp b/lib/Expr/Expr.cpp
> >index d177eca..1187573 100644
> >--- a/lib/Expr/Expr.cpp
> >+++ b/lib/Expr/Expr.cpp
> >@@ -206,7 +206,7 @@ unsigned ReadExpr::computeHash() {
> >  }
> >
> >  unsigned NotExpr::computeHash() {
> >-  unsigned hashValue = expr->hash() * Expr::MAGIC_HASH_CONSTANT * Expr::Not;
> >+  hashValue = expr->hash() * Expr::MAGIC_HASH_CONSTANT * Expr::Not;
> >    return hashValue;
> >  }
> >
> >