SAX/C++: C++-specific design principles

[David Megginson]

James Clark <jjc at jclark.com> writes:

> That's problematic for EntityResolve::resolveEntity; that requires that
> ownership of an InputSource be transferred from to the caller from the
> callee.
> 
> This could be avoided by doing:
> 
> virtual const InputSource *
> resolveEntity(const char *publicId,
>               const char *systemId);
> 
> instead of:
> 
> virtual void
> resolveEntity(const char *publicId,
>               const char *systemId,
>               InputSource &inputSource);

(I'll assume that James accidentally reversed the two).  The second
one is a very good idea -- the only modification I'd make is to add a
bool return value, so that the parser knows whether the resolver
actually wants to override:

virtual bool
 resolveEntity(const char *publicId,
               const char *systemId,
               InputSource &inputSource);


All the best,


David

-- 
David Megginson                 david at megginson.com
           http://www.megginson.com/

xml-dev: A list for W3C XML Developers. To post, mailto:xml-dev at ic.ac.uk
Archived as: http://www.lists.ic.ac.uk/hypermail/xml-dev/ and on CD-ROM/ISBN 981-02-3594-1
To unsubscribe, mailto:majordomo at ic.ac.uk the following message;
unsubscribe xml-dev
To subscribe to the digests, mailto:majordomo at ic.ac.uk the following message;
subscribe xml-dev-digest
List coordinator, Henry Rzepa (mailto:rzepa at ic.ac.uk)